HR/EMS31_submodules
Template
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

history: fix memory leak

Browse Source
This commit is contained in:
Laila van Reenen 2024-04-14 12:28:27 +02:00
parent e7ea706157
commit df2129a1bb
3 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
CLI/CLI.c
View File

@ -68,7 +68,7 @@ bool CLI_deinit()
FIFOBuffChar_delete(FIFO);
#ifdef HISTORY
History_deinit(History);
History_deinit(History, true);
#endif
return true;
}

2
CMDList/CMDList.c
View File

@ -44,7 +44,7 @@ int CMDList_add(CMDList_t *list, CMD_t* cmd, char* cmdName)
read_p = cmd->cmd;
}
while (returnCode == 0)
while (returnCode >= 0)
{
char c = *read_p & (~0x20); // convert to uppercase
if ((c >= 'A') && (c <= 'Z'))

6
History/History.c
View File

@ -19,7 +19,7 @@ History_t* History_init()
}
int History_deinit(History_t* history)
int History_deinit(History_t* history, bool freeLines)
{
// Check if the buffer there is something in the buffer
if (history->FirstEl_p == NULL)
@ -29,6 +29,10 @@ int History_deinit(History_t* history)
while (el != NULL)
{
History_element_t* nextEl = el->nextEl_p;
if (freeLines)
{
free(el->line);
}
free(el);
el = nextEl;
}