We have various places with overly simple if statements that could be handled by our logging library. Also a lot of those logs are not marked as debug logs but as info logs, which can cause confusion during debugging. This patch removed unneeded if clauses around debug logging statements, reworks debug log messages towards ECMA templates and add some new logging statements which might be helpful in order to debug things like image uploads. Signed-off-by: Sheogorath <sheogorath@shivering-isles.com>
		
			
				
	
	
		
			27 lines
		
	
	
		
			754 B
		
	
	
	
		
			JavaScript
		
	
	
	
	
	
			
		
		
	
	
			27 lines
		
	
	
		
			754 B
		
	
	
	
		
			JavaScript
		
	
	
	
	
	
| 'use strict'
 | |
| const config = require('../../config')
 | |
| const logger = require('../../logger')
 | |
| 
 | |
| const imgur = require('imgur')
 | |
| 
 | |
| exports.uploadImage = function (imagePath, callback) {
 | |
|   if (!callback || typeof callback !== 'function') {
 | |
|     logger.error('Callback has to be a function')
 | |
|     return
 | |
|   }
 | |
| 
 | |
|   if (!imagePath || typeof imagePath !== 'string') {
 | |
|     callback(new Error('Image path is missing or wrong'), null)
 | |
|     return
 | |
|   }
 | |
| 
 | |
|   imgur.setClientId(config.imgur.clientID)
 | |
|   imgur.uploadFile(imagePath)
 | |
|     .then(function (json) {
 | |
|       logger.debug(`SERVER uploadimage success: ${JSON.stringify(json)}`)
 | |
|       callback(null, json.data.link.replace(/^http:\/\//i, 'https://'))
 | |
|     }).catch(function (err) {
 | |
|       callback(new Error(err), null)
 | |
|     })
 | |
| }
 |