LailaTheElf/embassy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

remove first person comments

Browse Source
This commit is contained in:
Guilherme S. Salustiano 2024-02-12 13:21:01 +01:00
parent fdb15b2054
commit b4f0f57538
2 changed files with 7 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
embassy-nrf/src/lib.rs
View File

@ -46,7 +46,8 @@ pub mod gpio;
#[cfg(feature = "gpiote")] #[cfg(feature = "gpiote")]
pub mod gpiote; pub mod gpiote;
#[cfg(any(feature = "nrf52840"))] // needs to be tested on other chips // TODO: tested on other chips
#[cfg(any(feature = "nrf52840"))]
pub mod radio; pub mod radio;
#[cfg(any(feature = "nrf52832", feature = "nrf52833", feature = "nrf52840"))] #[cfg(any(feature = "nrf52832", feature = "nrf52833", feature = "nrf52840"))]

22
embassy-nrf/src/radio/ble.rs
View File

@ -1,15 +1,4 @@
//! Radio driver implementation focused on Bluetooth Low-Energy transmission. //! Radio driver implementation focused on Bluetooth Low-Energy transmission.
//!
//! The radio can calculate the CRC, perform data whitening,
//! automatically send the right preamble.
//! Most of the configuration is done automatically when you choose the mode and this driver.
//!
//! Some configuration can just be done when de device is disabled,
//! and the configuration varies depending if is a transmitter or a receiver.
//! Because of that we have a state machine to keep track of the state of the radio.
//! The Radio is the disable radio which configure the common parameters between
//! the bluetooth protocols, like the package format, the CRC and the whitening.
//! The TxRadio radio enable and configured as a transmitter with the specific parameters.
use core::future::poll_fn; use core::future::poll_fn;
use core::sync::atomic::{compiler_fence, Ordering}; use core::sync::atomic::{compiler_fence, Ordering};
@ -241,7 +230,7 @@ impl<'d, T: Instance> Radio<'d, T> {
.write(|w| unsafe { w.ap0().bits((access_address >> 24) as u8) }); .write(|w| unsafe { w.ap0().bits((access_address >> 24) as u8) });
// The base address is truncated from the least significant byte (because the BALEN is less than 4) // The base address is truncated from the least significant byte (because the BALEN is less than 4)
// So we need to shift the address to the right // So it shifts the address to the right
r.base0.write(|w| unsafe { w.bits(access_address << 8) }); r.base0.write(|w| unsafe { w.bits(access_address << 8) });
// Don't match tx address // Don't match tx address
@ -317,13 +306,12 @@ impl<'d, T: Instance> Radio<'d, T> {
/// Also if the buffer is smaller than the packet length, the radio will /// Also if the buffer is smaller than the packet length, the radio will
/// read/write memory out of the buffer bounds. /// read/write memory out of the buffer bounds.
fn set_buffer(&mut self, buffer: &[u8]) -> Result<(), Error> { fn set_buffer(&mut self, buffer: &[u8]) -> Result<(), Error> {
// Because we are serializing the buffer, we should always have the buffer in RAM
slice_in_ram_or(buffer, Error::BufferNotInRAM)?; slice_in_ram_or(buffer, Error::BufferNotInRAM)?;
let r = T::regs(); let r = T::regs();
// Here we are considering that the length of the packet is // Here it consider that the length of the packet is
// correctly set in the buffer, otherwise we will sending // correctly set in the buffer, otherwise it will send
// unowned regions of memory // unowned regions of memory
let ptr = buffer.as_ptr(); let ptr = buffer.as_ptr();
@ -374,7 +362,7 @@ impl<'d, T: Instance> Radio<'d, T> {
let s = T::state(); let s = T::state();
// If the Future is dropped before the end of the transmission // If the Future is dropped before the end of the transmission
// we need to disable the interrupt and stop the transmission // it disable the interrupt and stop the transmission
// to keep the state consistent // to keep the state consistent
let drop = OnDrop::new(|| { let drop = OnDrop::new(|| {
trace!("radio drop: stopping"); trace!("radio drop: stopping");
@ -417,7 +405,7 @@ impl<'d, T: Instance> Radio<'d, T> {
compiler_fence(Ordering::SeqCst); compiler_fence(Ordering::SeqCst);
r.events_disabled.reset(); // ACK r.events_disabled.reset(); // ACK
// Everthing ends fine, so we can disable the drop // Everthing ends fine, so it disable the drop
drop.defuse(); drop.defuse();
} }