From 9e9fa1cbefcd12bf3f645c02630b1566df864376 Mon Sep 17 00:00:00 2001 From: Ian McKernan Date: Wed, 1 Jan 2025 21:47:44 -0800 Subject: [PATCH 1/2] added fix for https://github.com/embassy-rs/embassy/issues/2496 in the v1 driver --- embassy-stm32/src/eth/v1/mod.rs | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/embassy-stm32/src/eth/v1/mod.rs b/embassy-stm32/src/eth/v1/mod.rs index cce75ece7..693355593 100644 --- a/embassy-stm32/src/eth/v1/mod.rs +++ b/embassy-stm32/src/eth/v1/mod.rs @@ -163,6 +163,11 @@ impl<'d, T: Instance, P: PHY> Ethernet<'d, T, P> { // TODO: Carrier sense ? ECRSFD }); + // Set the mac to pass all multicast packets + mac.macffr().modify(|w| { + w.set_pam(true); + }); + // Note: Writing to LR triggers synchronisation of both LR and HR into the MAC core, // so the LR write must happen after the HR write. mac.maca0hr() From 28d58578d69cc80653cf0620cbd22385749a5eb1 Mon Sep 17 00:00:00 2001 From: Ian McKernan Date: Wed, 1 Jan 2025 21:59:29 -0800 Subject: [PATCH 2/2] remove trailing space from comment --- embassy-stm32/src/eth/v1/mod.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/embassy-stm32/src/eth/v1/mod.rs b/embassy-stm32/src/eth/v1/mod.rs index 693355593..b96275cb7 100644 --- a/embassy-stm32/src/eth/v1/mod.rs +++ b/embassy-stm32/src/eth/v1/mod.rs @@ -163,7 +163,7 @@ impl<'d, T: Instance, P: PHY> Ethernet<'d, T, P> { // TODO: Carrier sense ? ECRSFD }); - // Set the mac to pass all multicast packets + // Set the mac to pass all multicast packets mac.macffr().modify(|w| { w.set_pam(true); });