diff --git a/embassy-stm32/src/usart/mod.rs b/embassy-stm32/src/usart/mod.rs index 49f536799..48f9a84fa 100644 --- a/embassy-stm32/src/usart/mod.rs +++ b/embassy-stm32/src/usart/mod.rs @@ -142,20 +142,20 @@ pub enum HalfDuplexReadback { pub enum OutputConfig { /// Push pull allows for faster baudrates, no internal pullup PushPull, - /// Open drain output using external pull down resistor - OpenDrainExternal, + /// Open drain output (external pull up needed) + OpenDrain, #[cfg(not(gpio_v1))] - /// Open drain output using internal pull up resistor - OpenDrainInternal, + /// Open drain output with internal pull up resistor + OpenDrainPullUp, } impl OutputConfig { const fn af_type(self) -> AfType { match self { OutputConfig::PushPull => AfType::output(OutputType::PushPull, Speed::Medium), - OutputConfig::OpenDrainExternal => AfType::output(OutputType::OpenDrain, Speed::Medium), + OutputConfig::OpenDrain => AfType::output(OutputType::OpenDrain, Speed::Medium), #[cfg(not(gpio_v1))] - OutputConfig::OpenDrainInternal => AfType::output_pull(OutputType::OpenDrain, Speed::Medium, Pull::Up), + OutputConfig::OpenDrainPullUp => AfType::output_pull(OutputType::OpenDrain, Speed::Medium, Pull::Up), } } } diff --git a/examples/stm32g0/src/bin/onewire_ds18b20.rs b/examples/stm32g0/src/bin/onewire_ds18b20.rs index 75519bbf2..62f8711a6 100644 --- a/examples/stm32g0/src/bin/onewire_ds18b20.rs +++ b/examples/stm32g0/src/bin/onewire_ds18b20.rs @@ -22,7 +22,7 @@ fn create_onewire(p: embassy_stm32::Peripherals) -> OneWire OneWire