LailaTheElf/embassy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

rp/adc: fix potential race condition

Browse Source 
This commit rearranges the Adc::wait_for_ready function to make sure
that wakers are registered before the interrupt is enabled, and keeps
enabling the interrupt until the ADC is ready
This commit is contained in:
Adrian Wowk 2025-03-26 17:11:27 -05:00
parent 9edf5b7f04
commit 1b6e563260
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
embassy-rp/src/adc.rs
View File

@ -205,11 +205,13 @@ impl<'d> Adc<'d, Async> {
fn wait_for_ready() -> impl Future<Output = ()> {
let r = Self::regs();
r.inte().write(|w| w.set_fifo(true));
compiler_fence(Ordering::SeqCst);
poll_fn(move |cx| {
WAKER.register(cx.waker());
r.inte().write(|w| w.set_fifo(true));
compiler_fence(Ordering::SeqCst);
if r.cs().read().ready() {
return Poll::Ready(());
}