From 9a022034a64b9ed57425d056483a8694fa940c98 Mon Sep 17 00:00:00 2001 From: Dave Rolsky Date: Sun, 16 Feb 2025 11:11:06 -0600 Subject: [PATCH] Add comment to remind myself why we need `cross` for Linux i586/i686 targets --- set-cross-compile.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/set-cross-compile.py b/set-cross-compile.py index 3ffc7e6..83bf096 100755 --- a/set-cross-compile.py +++ b/set-cross-compile.py @@ -61,6 +61,10 @@ def check_needs_cross(target: str) -> bool: ): return False + # It's tempting to not use cross when the host is Linux x86-64 and we're compiling for Linux + # i586 or i686. This sort of works, but if there's any C being compiled, things get weird, + # because then we need 32-bit C headers, 32-bit C libs to link to, etc. + # Check if both host and target are ARM Linux. I'm assuming here that for things like # "arm-linux-androideabi" or "armv7-unknown-linux-ohos" we'd still need cross. if (